Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve memory footprint of peer metric #4620

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Improve memory footprint of peer metric #4620

merged 1 commit into from
Jul 17, 2023

Conversation

coot
Copy link
Contributor

@coot coot commented Jul 10, 2023 •
edited
Loading

Description

Without the evaluation improvements we have a space leak (observed with ghc-9.2.7):
image

with the changes the space leak goes away:

image

Checklist

  • Branch
    • Updated changelog files.
    • Commit sequence broadly makes sense
    • Commits have useful messages
    • The documentation has been properly updated
    • New tests are added if needed and existing tests are updated
    • If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.
  • Pull Request
    • Self-reviewed the diff
    • Useful pull request description at least containing the following information:
      • What does this PR change?
      • Why these changes were needed?
      • How does this affect downstream repositories and/or end-users?
      • Which ticket does this PR close (if any)? If it does, is it linked?
    • Reviewer requested

@coot coot requested a review from bolt12 July 10, 2023 17:02
bolt12
bolt12 approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jasagredo
Copy link
Contributor

Oops I didn't mean to push to this branch, let me undo that

@jasagredo jasagredo force-pushed the coot/strict-peer-metric branch 2 times, most recently from 3a82e6b to 57151bc Compare July 13, 2023 09:39
@coot coot added this pull request to the merge queue Jul 17, 2023
@coot coot removed this pull request from the merge queue due to a manual request Jul 17, 2023
@coot coot enabled auto-merge July 17, 2023 07:12
@coot coot added this pull request to the merge queue Jul 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2023
@bolt12 bolt12 added this pull request to the merge queue Jul 17, 2023
Merged via the queue into master with commit 5553ebe Jul 17, 2023
6 checks passed
@bolt12 bolt12 deleted the coot/strict-peer-metric branch July 17, 2023 09:30
@coot coot mentioned this pull request Jul 25, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

@jorisdral jorisdral jorisdral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coot @jasagredo @bolt12 @jorisdral